Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: temporary fix for deadlink in Jenkins on Google Cloud tutorial #7602

Merged
merged 9 commits into from
Oct 14, 2024

Conversation

yashpal2104
Copy link
Contributor

@yashpal2104 yashpal2104 commented Oct 12, 2024

Fixes #7589

Fixed the broken link for the tutorial to set up Jenkins on Google Cloud by inserting a video in place of the original deadlink. It can be modified later if someone wants to take the next step of creating text that describes how to use Jenkins on Google Cloud.

@yashpal2104 yashpal2104 requested a review from a team as a code owner October 12, 2024 15:32
@yashpal2104
Copy link
Contributor Author

@krisstern @zbynek how does this look to you

@krisstern krisstern changed the title Temporary Fix for the deadlink for user guide documentation of setting up jenkins on google cloud bug: temporary fix for deadlink in user guide on setting up jenkins on google cloud Oct 12, 2024
@krisstern krisstern changed the title bug: temporary fix for deadlink in user guide on setting up jenkins on google cloud bug: temporary fix for deadlink in Jenkins on Google Cloud tutorial Oct 12, 2024
@krisstern
Copy link
Member

@yashpal2104 Looking good like the below now:

Screenshot 2024-10-13 at 1 07 18 AM

The preview link is at https://deploy-preview-7602--jenkins-io-site-pr.netlify.app/doc/tutorials/tutorials-for-installing-jenkins-on-google-cloud/.

Copy link
Member

@krisstern krisstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yashpal2104
Copy link
Contributor Author

Wohooooo... Boy it really was work🥲🥳

@krisstern
Copy link
Member

krisstern commented Oct 12, 2024

I will wait until another maintainer gets the chance to review this PR before it can be merged

@gounthar gounthar enabled auto-merge (squash) October 14, 2024 08:50
@gounthar gounthar merged commit 6c35f3c into jenkins-infra:master Oct 14, 2024
4 of 6 checks passed
@yashpal2104 yashpal2104 deleted the fix-broken-link branch October 22, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link
4 participants